PSA: `make check` no longer runs `go test -i ./...`

Open Source Contributors
#1

This step was originally added to avoid false positives from go vet. However, it seems likely that go vet has since improved in this regard.

Please ping this thread or the PR (https://github.com/cockroachdb/cockroach/pull/9948) if you observe regressions.

#2

No joy https://github.com/cockroachdb/cockroach/pull/9948#issuecomment-253755727

I haven’t seen any others fail; it is probably safe to run the command as part of TestVet only.

#3

Indeed, it seems that quite a few tools are affected. @tschottdorf filed https://github.com/cockroachdb/cockroach/issues/9983 to track.